Skip to content

Fix chat scroll reset animation race#2005

Merged
crossle merged 2 commits into
mainfrom
fix/chat-scroll-reset-animation
Jul 9, 2026
Merged

Fix chat scroll reset animation race#2005
crossle merged 2 commits into
mainfrom
fix/chat-scroll-reset-animation

Conversation

@YeungKC

@YeungKC YeungKC commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • cancel pending programmatic bottom scrolls before resetting a chat scroll window
  • prevent stale latest animations from moving unread/center anchors after conversation changes
  • add a regression test for resetting while a latest animation is still running

Tests

  • flutter test test/ui/home/chat/chat_scroll_coordinator_test.dart

@YeungKC YeungKC requested a review from crossle July 9, 2026 01:38
…-animation

# Conflicts:
#	lib/ui/home/chat/chat_scroll_coordinator.dart
@crossle crossle enabled auto-merge (squash) July 9, 2026 04:27
@YeungKC YeungKC requested a review from boyan01 July 9, 2026 04:31
@crossle crossle merged commit af41295 into main Jul 9, 2026
3 checks passed
@crossle crossle deleted the fix/chat-scroll-reset-animation branch July 9, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants